[MLA-1939] Match3 Custom Editor #5263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriselion
commented
Apr 14, 2021
|
|
||
| if (requireSensorUpdate) | ||
| { | ||
| UpdateActuator(); |
There was a problem hiding this comment.
Not needed, but keeping in place if we need it later. Can remove if desired.
dongruoping
approved these changes
Apr 15, 2021
| @@ -1,4 +1,3 @@ | |||
| using Unity.MLAgents; | |||
There was a problem hiding this comment.
nit: There's another one in actuator component
There was a problem hiding this comment.
I'll do a pass on Rider suggestions later.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
editorForChildClasses: truefor other custom editors where appropriate (e.g. not BehaviorParameters, but most others).